C blitbuffer implementation #571
Conversation
| @@ -766,7 +766,7 @@ local function get_pthread() | |||
| else | |||
| -- Kobo devices strangely have no libpthread.so in LD_LIBRARY_PATH | |||
| -- so we hardcode the libpthread.so.0 here just for Kobo. | |||
| for _, libname in ipairs({"libpthread.so", "libpthread.so.0"}) do | |||
| for _, libname in ipairs({"pthread", "libpthread.so.0"}) do | |||
There was a problem hiding this comment.
I saw this before and wondered about changing it, but I figured there might've been a reason for it (though I can't think of any). :-)
There was a problem hiding this comment.
Yeah, benefit is that it can load libpthread.dylib on Mac now. Btw, this PR is developed solely on my Mac. Koreader is stable enough on Mac OSX now for development purpose. :)
There was a problem hiding this comment.
Cool. :)
Btw, I wanted to look into that Travis Mac build business, but at least on Travis that's not an option due to insufficient resources. See #564 (comment) (I imagine everything would fail spectacularly as written there, but that aside. I just wanted to play around with it a bit.)
There was a problem hiding this comment.
I'm not sure if the brew install stuff is sufficient. Probably there are hidden hacks on my Mac to make it work. Anyway I will verify that on a clean Mac when I have time.
ffi/blitbuffer.lua
Outdated
| self.setPixelBlend) | ||
| local color = Color8A(255, 255*(by or 0.5)) | ||
| if use_cblitbuffer then | ||
| c = color:getColorRGB32() |
There was a problem hiding this comment.
I think this line should probably be removed?
Includes C blitbuffer implementation koreader/koreader-base#571 by @chrox Should help performance degeneration on Android due to mcode allocation failure, see koreader#1416
Includes C blitbuffer implementation koreader/koreader-base#571 by @chrox Should help performance degeneration on Android due to mcode allocation failure, see #1416
|
Just curious: why did you decide to not enable it for other platforms? Isn't pure C faster that JIT compiled lua? |
|
It's FFI data structures so they're faster (or should be) than Lua C API I think. Easier to maintain in any case. But the problem here is memory allocation on Android, not blitting performance. |
|
Actually I didn't make a real performance benchmark on the two blitbuffer implementations. The lua implementation is elegant and easy to extend. This one is intended to be used on platforms on which jit does not work. |
The C implementation is only built for the Android platform and the Emulator. With this patch mcode allocation failure on Android don't degenerate the performance. And we can even disable
jiton Android that also means we can port Koreader to iOS on whichjitis disabled by the system.This implementation does not change the
blitbufferAPI and is transparent to thefrontend.