[fix] SDL2: resolve rotation issues #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embarrassingly, I recently introduced two (!) regressions in rotation handling. 1. The new blitbuffer created when resizing didn't take rotation into account. Cf. koreader#614 2. The feature to emulate E Ink refresh didn't properly distinguish between BB rectangles and "physical" SDL rectangles. Cf. koreader#626 Reported by @poire-z in koreader/koreader#3812 (comment)
|
@poire-z Any comments before I merge? |
|
Code-wise, I'm too far from being familiar or remembering that part to say a word. |
|
It just occurred to me that the first issue technically isn't a regression at all. The window never resized before, after all. ;-) |
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
May 5, 2018
Includes: * [feat] Add dropbear as an SSH server koreader/koreader-base#640 * [fix] SDL2: resolve rotation issues koreader/koreader-base#665 * [fix, build] Makefile target should be dropbearmulti, not dropbear koreader/koreader-base#666 * bump crengine for: Fix a few CSS selector issues koreader/koreader-base#668
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
May 5, 2018
Includes: * [feat] Add dropbear as an SSH server koreader/koreader-base#640 * [fix] SDL2: resolve rotation issues koreader/koreader-base#665 * [fix, build] Makefile target should be dropbearmulti, not dropbear koreader/koreader-base#666
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
May 5, 2018
Includes: * [feat] Add dropbear as an SSH server koreader/koreader-base#640 * [fix] SDL2: resolve rotation issues koreader/koreader-base#665 * [fix, build] Makefile target should be dropbearmulti, not dropbear koreader/koreader-base#666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embarrassingly, I recently introduced two (!) regressions in rotation handling.
Reported by @poire-z in koreader/koreader#3812 (comment)