[fix] HarfBuzz Android build with newer libtool #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Oct 30, 2018
Includes: * [fix] HarfBuzz Android build with newer libtool koreader/koreader-base#749 * [CI] Update Docker images koreader/koreader-base#748
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Oct 30, 2018
Includes: * [fix] HarfBuzz Android build with newer libtool koreader/koreader-base#749 * [CI] Update Docker images koreader/koreader-base#748
|
Any idea why this one slipped through the cracks before the bump? |
|
Travis and the old Docker image are on 14.04 with old libtool and I guess no one's built their own Android binaries for a couple of months. We should replace the ancient Android tc with the Docker container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. #521