Leave bitness-dependent types alone in FFI stuff #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not that we care, but, still ;p.
The SEND_UPDATE appears to have previously pointed to the Kobo ioctl?!
|
Note that in most cases, when that applies to a function argument, it's not dramatic... unless it's a pointer, because we'll have to ffi.new it. If, on the other hand, you're allocating a struct with fields using one of those types, that's where hilarity ensues... |
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Feb 21, 2019
* Leave bitness-dependent types alone in FFI stuff koreader/koreader-base#825 @NiLuJe Required for koreader#4629. * A few blitting changes for better BB8 performance koreader/koreader-base#816 @NiLuJe
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Feb 21, 2019
* Leave bitness-dependent types alone in FFI stuff koreader/koreader-base#825 @NiLuJe Required for #4629. * A few blitting changes for better BB8 performance koreader/koreader-base#816 @NiLuJe
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
…4631) * Leave bitness-dependent types alone in FFI stuff koreader/koreader-base#825 @NiLuJe Required for koreader#4629. * A few blitting changes for better BB8 performance koreader/koreader-base#816 @NiLuJe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffi-cdecl unfortunately converts them to their native type based on the compiler used, which may lead to hilariously annoying to debug memory corruption issues (c.f., #816 ...) given that we can run both on 32bit (arm) & 64bit (x86_64)....
The posix cdecl tried to handle that by forcing a cdecl_type on 'em, but that doesn't quite work, so, do the same arch-dance as pthread ;).