[build] Use Ninja by default when available #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Mar 16, 2019
…lable The difference for builds from scratch is negligible, but for rebuilds (i.e., us hackers & the CI here in front) it should bring a speed improvement. Cf. koreader/koreader-base#861, koreader/koreader-base#862 and https://github.com/koreader/virdevenv/pull/34/files
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Mar 16, 2019
…lable (#4808) The difference for builds from scratch is negligible, but for rebuilds (i.e., for us hackers & the CI here in front) it should bring a speed improvement. Automatic fallback to Make when Ninja is not available, or override with `USE_MAKE=1`. You can (theoretically) choose your own generator with a sensible combination of `CMAKE_FLAGS` and `CMAKE_MAKE_PROGRAM`. I also added `MAKE_FLAGS` and `NINJA_FLAGS`. That way you can easily pass `MAKE_FLAGS=-n` or `NINJA_FLAGS=-n` for a dry run, for example. To switch you might have to run something like `make dist-clean USE_MAKE=1`. Cf. koreader/koreader-base#861, koreader/koreader-base#862 and https://github.com/koreader/virdevenv/pull/34/files
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
…lable (koreader#4808) The difference for builds from scratch is negligible, but for rebuilds (i.e., for us hackers & the CI here in front) it should bring a speed improvement. Automatic fallback to Make when Ninja is not available, or override with `USE_MAKE=1`. You can (theoretically) choose your own generator with a sensible combination of `CMAKE_FLAGS` and `CMAKE_MAKE_PROGRAM`. I also added `MAKE_FLAGS` and `NINJA_FLAGS`. That way you can easily pass `MAKE_FLAGS=-n` or `NINJA_FLAGS=-n` for a dry run, for example. To switch you might have to run something like `make dist-clean USE_MAKE=1`. Cf. koreader/koreader-base#861, koreader/koreader-base#862 and https://github.com/koreader/virdevenv/pull/34/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add an easy way to pass some flags downstream.