Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix, Android] Versioned OpenSSL libs #894

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Apr 19, 2019

Unversioned is a proven recipe for disaster. #thanksandroid

But perhaps more to the point, this isn't just a personal fancy. It crashes on load.

Unversioned is a proven recipe for disaster. #thanksandroid

But perhaps more to the point, this isn't just a personal fancy. It crashes on load.
@Frenzie Frenzie added the bug label Apr 19, 2019
@NiLuJe
Copy link
Member

NiLuJe commented Apr 19, 2019

OpenSSL's build system automatically generates those on Android targets, so it may take some extra shenanigans to handle the rename earlier in the CMake file?

@Frenzie
Copy link
Member Author

Frenzie commented Apr 19, 2019

There's no rename involved. I'm not really sure why you used the unversioned one?

@Frenzie
Copy link
Member Author

Frenzie commented Apr 19, 2019

Screenshot_2019-04-19_15-47-32

@NiLuJe
Copy link
Member

NiLuJe commented Apr 19, 2019

I vaguely thought there was only one and the copy would then fail ;).

libjpeg-turbo did this, so I went the proactive way during a build without checking ;).

@Frenzie
Copy link
Member Author

Frenzie commented Apr 19, 2019

Yes, OpenSSL is either purposefully going against Android's beyond idiotic policy as it very well should, or it's sufficiently up-to-date that it's ready for Android 8+. The latter decided to reverse this particular tidbit of broken by design idiocy.

It doesn't exactly help that the Android linker is total piece of trash that functions and reads like something I could write. When that is the case in something this low-level it's either incredibly elegant or rather shitty.

@Frenzie Frenzie merged commit 96e1c7f into koreader:master Apr 19, 2019
@Frenzie Frenzie deleted the fix-android-openssl branch April 19, 2019 14:07
Frenzie added a commit to Frenzie/koreader that referenced this pull request Apr 19, 2019
* scale density independent pixel by 160 instead of 167 koreader/koreader-base#885
* [fix, Android] Versioned OpenSSL libs koreader/koreader-base#894
Frenzie added a commit to koreader/koreader that referenced this pull request Apr 19, 2019
* scale density independent pixel by 160 instead of 167 koreader/koreader-base#885
* [fix, Android] Versioned OpenSSL libs koreader/koreader-base#894
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
* scale density independent pixel by 160 instead of 167 koreader/koreader-base#885
* [fix, Android] Versioned OpenSSL libs koreader/koreader-base#894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants