Re-enforce silent builds for iconv & gettext #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only build them on Android, but they are *extremely* verbose, which the CIs don't appreciate ;).
|
Linking my comment about making it depend on the environment: #893 (comment) (Not too important here.) I think GitLab doesn't really care about the log size, but that it just annoyingly only shows you the first lines instead of the last lines. Which is not a great conclusion if true. ;-) It's only Travis that actively punishes log size. |
Frenzie
approved these changes
Apr 21, 2019
|
Yeah, in this instance I don't have much qualms about enforcing it to silent, since it's all pretty boring stuff anyway ;). |
|
(Doesn't need testing.) |
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Apr 21, 2019
Otherwise Travis CI and GitLab CI have log length issues on Android. koreader/koreader-base#898
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
Otherwise Travis CI and GitLab CI have log length issues on Android. koreader/koreader-base#898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only build them on Android, but they are extremely verbose,
which the CIs don't appreciate ;).