Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Possible to customize the behaviour and position of the long-press, pop-up menu? #11081

Closed
adamsitar opened this issue Nov 5, 2023 · 5 comments · Fixed by #11116
Closed
Milestone

Comments

@adamsitar
Copy link

Talking about this menu:
image

Does your feature request involve difficulty completing a task? Please describe.
I think this behavior for the popup menu could be more ergonomic, most people hold the e-reader in a portrait mode, so the menu appearing at the bottom of the screen would be easier and more comfortable to access - especially for when the reader is used for language learning purposes

Describe the solution you'd like
The popup menu already is draggable - I wish it would remember the location (or the location could be set somewhere in the menu or a lua config file, aka top | center | bottom), so it's not always displayed in the center of the screen

Describe alternatives you've considered
I just use the menu as it is, or always quickly drag it down where it is more reachable

Additional context
If the customization is possible through a lua file somewhere already, that would be awesome

Thank you!

@ryanwwest
Copy link
Contributor

I share the interest in remembering the position of this and other dialogs. I have a 13 inch ereader and sometimes it would be nice for this and other dialogs to open closer to the bottom of the screen. Not sure how to design a good implementation though.

@jonnyl2
Copy link

jonnyl2 commented Nov 15, 2023

Possibly this pop-up menu could (optionally?) be made to open anchored to where the finger was lifted for a selection?
C.f. #10631 (FR: Open QuickMenu pop-ups at location of gesture).

I usually do selections/highlights with my index finger rather than my thumb, so the pop-up location hasn't been bothering me too much (much easier to reach with the index finger). However, now that I think about it, I think I would also prefer it to open right where I select a word or end a selection of a block of text.

@mergen3107
Copy link
Contributor

My main gripe with the popup menu is that if the selected words are in the middle, the popup menu shows up and covers them completely.

I remember on very old Kindles (Keyboard and 4 Non-Touch), depending on the word selection the dictionary popup shows up at the top or the bottom of the screen.

@NiLuJe
Copy link
Member

NiLuJe commented Nov 16, 2023

I seem to recall that we do position the popup relative to the selection box (at least when selecting a single word for sure). Then again, I'm thinking of the actual Dictionary popup, not the "choose your own adventure" one you guys seem to be talking about ;p.

@mergen3107
Copy link
Contributor

Ah, sorry - I don't know what single word selection popup looks like because I made it go to dictionary right away :D

@hius07 hius07 added this to the 2023.11 milestone Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants