Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: arbitrary zooming mode with pinch-to-zoom gestures for PDF documents #1210

Closed
serdar0020 opened this issue Nov 19, 2014 · 11 comments
Closed

Comments

@serdar0020
Copy link

I use this for non OCR'd pdf's when the print is too small for portrait mode, but too large to spread over the entire width in landscape mode. It used to be possible with koreader a couple of months ago, by wiping the vertical borders into the dark grey area, manual cropping mode

But no longer. Using Kobo Aura 6", FW 3.11, built 1141

@chrox
Copy link
Member

chrox commented Nov 21, 2014

Currently we cannot add arbitrary page margins around PDF pages, visible margins should always be smaller than the original margins. And cropping box exceeding page native size will be bounded to the native page box. The behavior of koreader with cropping box exceeding page native size is undefined and should not be relied on.

More discussions on this issue can be found here: #970

@chrox
Copy link
Member

chrox commented Nov 21, 2014

And manual cropping is not the right way to solve your problem though it might work previously. An arbitrary zooming mode with pinch-to-zoom gestures should do the work. I will label this issue to a feature request.

@chrox chrox changed the title pdf in landscape mode, expanding the borders into grey area FR: arbitrary zooming mode with pinch-to-zoom gestures for PDF documents Nov 21, 2014
@serdar0020
Copy link
Author

thank you chrox. I'll check the latest versions then, hoping the "arbitrary zooming mode with pinch-to-zoom gestures" will be included. I have a lot of pdf's with very narrow margins, my own scans mostly, and I need this feature.

@chrox
Copy link
Member

chrox commented Nov 26, 2014

I'm afraid this feature won't be included in the upcoming stable version.

@adamvoss
Copy link

+1

2 similar comments
@volfyd
Copy link

volfyd commented Jul 15, 2016

+1

@woojoo666
Copy link

+1

@Frenzie Frenzie added the UX label Aug 8, 2017
@Aliallameh
Copy link

what happened to this feature?

@Frenzie
Copy link
Member

Frenzie commented Dec 23, 2018

It's been waiting for someone motivated to come along? :-)

@goodevilgenius
Copy link

Not just PDFs, but any fixed size files, like comic archives, e.g.

@Frenzie Frenzie mentioned this issue Nov 24, 2020
@poire-z
Copy link
Contributor

poire-z commented Jan 21, 2022

Probably solvable with the added zoom stuff from #6885.

@poire-z poire-z closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants