Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the gesture to adjust Frontlight #2096

Closed
Immick opened this issue Jun 20, 2016 · 6 comments
Closed

Changing the gesture to adjust Frontlight #2096

Immick opened this issue Jun 20, 2016 · 6 comments

Comments

@Immick
Copy link

Immick commented Jun 20, 2016

  • KOReader version: all
  • Device: Kobo Glo HD

Issue

As known to adjust Frontlight on Kobo devices you have to use two fingers. In nickel you need to use only one finger on the left side of the screen. I guess the second way (like in Nickel) is more comfortable.
So maybe someone knows how to implement adjusting Frontlight by swiping up and down with one finger on the left (right) side of the screen?

On mobilread there is already the solution but here the sliding up or down dose not behave exactly the same as nickel. It will not refresh the frontlight level as you slide, but only after finishing the gesture.

So the good idea is create the same behaviour as in nickel.

Thank you!

@houqp
Copy link
Member

houqp commented Jun 22, 2016

I think it's better to make it configurable, preferably with a plugin. Someone else will prefer two finger scroll ;P

@Brnoch
Copy link

Brnoch commented Jun 30, 2016

This post made me discover this useful functionality...
For me the fact that you need to use two fingers is not a big deal.
But I'd like to use it to disable / enable the front light: could it set the light to 0 ? Presently it can't go under 1.

@chrox
Copy link
Member

chrox commented Jun 30, 2016

On kobo it does not decrease to 0 because of this:

local KoboPowerD = BasePowerD:new{
    -- Do not actively set front light to 0, it may confuse users -- pressing
    -- hardware button won't take any effect.
    fl_min = 1, fl_max = 100,
    fl_intensity = 20,
    restore_settings = true,
    fl = nil,

So this is by design, but it could be optimized for example only for devices that have hardware light toggler button.

@Brnoch
Copy link

Brnoch commented Jun 30, 2016

Could be great if you could allow to decrease the light to 0 on devices like the Kobo Glo HD!

@chrox chrox closed this as completed Jun 30, 2016
@chrox chrox reopened this Jun 30, 2016
@robert00s
Copy link
Contributor

@Brnoch
Copy link

Brnoch commented Mar 20, 2017

Yes, it works!

@houqp houqp closed this as completed Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants