Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backlight control does not work properly on C67ML #2105

Closed
gerroon opened this issue Jun 25, 2016 · 14 comments
Closed

Backlight control does not work properly on C67ML #2105

gerroon opened this issue Jun 25, 2016 · 14 comments

Comments

@gerroon
Copy link

gerroon commented Jun 25, 2016

  • KOReader version:
    koreader-nightly-20160624
  • Device:
    C67ML

Issue

The backlight control works half baked

Steps to reproduce

Open the light settings and put a number. Wait for the light to change (which does not happen)

Changing the light level works after enabling and disabling the light. Basically KR changes the light setting but the setting is not applied right away. I have to disable and reenable (using the hardware button) to see the new screen light setting.

It seems to work better on my other android devices although the degree of the light setting is different on different models ( like amoled vs ips). The same number can mean different intensities on different devices.

thanks

@gerroon
Copy link
Author

gerroon commented Jun 25, 2016

Hmmm

Something is wonky on my other android devices. It seems like when I set it the first time my screen goes black (on Amoled). And it crashes on Toggling. I will try to get a log later.

@chrox
Copy link
Member

chrox commented Jun 25, 2016

Could you adjust the light intensity with two-finger vertical swiping?

@gerroon
Copy link
Author

gerroon commented Jun 25, 2016

@chrox

Swiping works but it is like the original post. I have to disable and enable the light via the hardware ey to see the actual change. When I do swiping, I see the numbers changing at the top with no real affect. I have to do hardware way of toggling to get the real light intensity to be shown on the device.

@gerroon
Copy link
Author

gerroon commented Jun 25, 2016

I wonder if this is related to the refresh issues I reported earlier.
#1955

@gerroon
Copy link
Author

gerroon commented Jul 3, 2016

This controls brightness fine
echo 100 >/sys/class/backlight/rk28_bl/brightness

Anyother method is not refreshing the brightness. I tried couple "lcd" brightness apps, they modify the brightness but the result is not visible right away, until I enable or disable the light or click on the tray bar

@houqp
Copy link
Member

houqp commented Jul 3, 2016

We control brightness through the standard android API. I think the other apps go with the same approach too. Are you saying writing to /sys/class/backlight/rk28_bl/brightness works without needing to toggle to refresh?

@gerroon
Copy link
Author

gerroon commented Jul 4, 2016

@houqp

Yes that does not require a refresh. My gut feeling is that the Android brightness settings for the einks are different than the brightness settings for the tablets with the lcds naturally.

The apps that I tried for changing brightness for Android(including Koreader) fails to change the brightness or the frontlight right away on my C67ML (eink android device), some sort of manual refreshing is needed afterwards. The only app that was able to do was rootdim or using the method I described above.

@houqp
Copy link
Member

houqp commented Jul 5, 2016

Judging from the name rootdim, I bet it also write to the file directly like you did ;P

Looks like we need to make a special case for C67ML in the code. Are all ONYX BOOX readers based on android?

@gerroon
Copy link
Author

gerroon commented Jul 5, 2016

@houqp

I am guessing that this might be an issue with all the EInk Android devices.

As far as I know Onyx makes Android devices though one of its models might be just a Linux based.

My device is rooted so if KR needs root permissions it is not a problem for me however I do not know how other people feel about it.

@verge-36
Copy link

Hello. I have a rooted NOOK Glowlight Plus, which is also an Android based E-Ink(Carta?) device. I don't think it is an issue with all eink android devices.
Two finger vertical scrolling isn't working for me(Usually crashes). But using Menu-Frontlight to apply screen brightness works fine.Screen usually goes black when i first set it, I tap once then it is fixed.I can change it with no black screen issue, no problems until i exit the app. Can normally change it after first black screen.
My device doesn't support full screen refresh with koreader. Maybe it is in some way related? I uploaded strace and logcat to a closed issue i opened(#2034) about this btw. Hope it can be easily implemented soon :D
--Sorry for bad english--

@gerroon
Copy link
Author

gerroon commented Jul 11, 2016

I get the initial blackness with my all android devices (lcd and eink)

@Frenzie Frenzie added the Android label Apr 1, 2017
@Frenzie Frenzie added the bug label Oct 9, 2017
@Frenzie
Copy link
Member

Frenzie commented Oct 9, 2017

@gerroon Is this affected by #3319?

@gerroon
Copy link
Author

gerroon commented Oct 9, 2017

The device was sold sometime ago ;)

@Frenzie
Copy link
Member

Frenzie commented Oct 9, 2017

I'll close it as lacking information then. ;-) (It just distracts otherwise.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants