slow bookmarks?

[Eduardomb22]

• KOReader version: lastest version
• Device: ppw3

Issue

Is the bookmark menu kind slow? It is taking some time to enter here, PDF or EPUB files.

[poire-z]

If your bookmarks are highlights with long text, yes, it may have become slow since a few nightlys, see #3589 (comment). Hopefully it will be fixed soon.

[Eduardomb22]

Thanks. It is probably this.

[Frenzie]

Yep, some semi-random comments in a closed issue/PR are a bit hard to find. ;-)

[robert00s]

@Eduardomb22
Can you check your bookmark menu after my patch #3657?

[Eduardomb22]

@robert00s, I'm not a programmer so I've tried to copy the menu.lua (or add and remove the lines from the file) to mine menu.lua. But I'm getting this error when I open a book and click in the bookmarks menu (It doesn't crash if the book doesn't have any bookmark saved)

02/02/18-14:43:23 WARN sizeUtf8Text called without text
02/02/18-14:43:23 WARN sizeUtf8Text called without text
02/02/18-14:43:23 WARN sizeUtf8Text called without text
02/02/18-14:43:23 WARN sizeUtf8Text called without text
lipc-wait-event exited normally with status: 0
Segmentation fault

I don't know if I'm doing right (probably it is my fault), so I think it is better to wait someone that could test it.

[robert00s]

Strange.
Unzip this file and replace menu.lua in frontend/ui/widget
menu.lua.zip
Edit: I have the same error on my kindle.

[robert00s]

Problem is with this line:
self.text = table.concat(table.move(item_name.charlist, 1, offset - 4, 1, {})) .. "…"

[Eduardomb22]

You can ping me so I can test it again. Thanks for looking into the problem.

[poire-z]

Fixed by #3657.