Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPDS catalogs don't display the authors of books listed #4258

Closed
y-muller opened this issue Oct 6, 2018 · 7 comments
Closed

OPDS catalogs don't display the authors of books listed #4258

y-muller opened this issue Oct 6, 2018 · 7 comments

Comments

@y-muller
Copy link
Contributor

y-muller commented Oct 6, 2018

  • KOReader version: v2015.11-1800 2018-07-29
  • Device: Kobo Clara HD

Issue

When browsing an OPDS catalog, only the book titles are displayed, not the authors. It is not very user friendly, especially when browsing by "Most popular" or "Recent entries".
Displaying the author in smaller size under the title, in a similar way to local books, would be very helpful.

Steps to reproduce

Menu > OPDS Catalog > ManyBooks (for example) > New Titles
Only the book titles are displayed.

Comment

In opdsbrowser.lua both the title and author are known.

@Frenzie
Copy link
Member

Frenzie commented Oct 7, 2018

Didn't you do some stuff in the OPDS browser recently @robert00s ?

@KenMaltby
Copy link

Are the category lists a feature of the OPDS catalog that calibre generates, if so what elements are available for each listing, in each category, may have been determined by calibre.

@y-muller
Copy link
Contributor Author

I'm starting to find my way in the codebase. I can do this, with the author under the title:
opds_proposal

or this, with the author after the title (could be the other way around too):
opds_proposal2

I think two separate lines look nicer. But the single line is what the file browser looks like in classic mode. Comments?

I don't see an easy way of making it look like the CoverBrowser, unfortunately.

@Frenzie
Copy link
Member

Frenzie commented Oct 18, 2018

Two lines is fine by me.

@y-muller
Copy link
Contributor Author

I'll make a PR for this. It's a super simple fix that makes the OPDS browser so much easier to use.

Am I correct in my assumption that the CoverBrowser is tied to the file manager and can't be used to show the data from external catalogs? Some OPDS servers provide a cover thumbnail and other bits of info.

@poire-z
Copy link
Contributor

poire-z commented Oct 18, 2018

Am I correct in my assumption that the CoverBrowser is tied to the file manager and can't be used to show the data from external catalogs?

Yes, you are correct.
I've done it in the context of browsing files, with caching metadata in a sqlite db, and background extraction of metadata, and getting back cached metadata from the sqlite db.
So, it probably can't be used as-is easily for something else .

But the code is splitted into parts that deal with displaying alternative views (mosaicmenu, listmenu, parts of covermenu), code for overriding Menu in the context of FileBrowser and History (main.lua, parts of covermenu, quite twisted to make it work to not touch the original core code) and code for caching/extraction/background jobs (bookinfomanager).

If I were to want to use it in other contexts, I would probably extend some parts to accept a BookinfoProvider, which would be the BookInfoManager by default, but could be some other kind of object (OPDSBookinfoProvider) that would not need to do any caching/background (so, no-op for some methods) and would just give back some similar table as the bookinfo objects that are made from the db (title, author, covers, nb of page...). The background extraction and re-update of the items could even be used to fetch the cover images only when needed, and there would just be a in-memory cache of already fetched cover in that OPDS browsing session).

So, it's a quite big project, but seems do-able if you feel adventurous.

(Dunno how twisted/hacky it could be plugged into OPDSCatalog from the plugin, so this plugin may need to be morphed into widgets into core for easier re-use - which is another adventure, see #3488 (comment))

@y-muller
Copy link
Contributor Author

Thanks for the details @poire-z . I think for the moment I'll stick to easier changes; still figuring things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants