-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light warmth automatic adjustment, set time light stays at Max. warmth #5372
Comments
I am using a Kobo Clara HD, but imagine this could be done for all readers with adjustable warmth fronlights. When I set the frontlight's warmth to 'Auto', I can set the time at which it reaches the maximum warmth. After that time (23:00) the light starts to get whiter again and reaches maximum whiteness around 02:00. What I would really like is to be able to set the time when it reaches maximum warmth, AND set how many hours it will stay at maximum warmth, after which the light will progressively get cooler. Would it be possible to add this in to KoReader? |
Could you also include a link to the MR discussion? |
Certainly, here it is, thanks! |
Looks like these lines: koreader/frontend/device/kobo/powerd.lua Lines 269 to 270 in 840d05b
|
i am no coder, but it looks like it would be simple to set it to stay at max warmth for longer (personally I would like 6-8 hours), but ideally there would be a user setting in the 'Frontlight' dialogue. |
I think 22 is just 24 – 2, where 2 is the number of hours to keep the max value. This function currently looks to be at risk of being tripled, see #5331. It should migrate to BasePowerD. |
I think we have some time to migrate common code before merging #5331. |
Volunteering? :-D |
Just to add my two cents, it would be really nice option to have (i.e. option how many hours it stays at maximum). Also, there could be option how many hours it takes to "fade in/out" from min to max. If there's none I mean. Because, I don't mess with light temperature myself, but I imagine that it would be pretty nice to have these two options:
|
|
For the refactor yeah! For this PR nope!. I will give it a look tomorrow |
Well, there can be also this one:
I think these 4 options would cover all. :D |
I think we might close this (and mark as solved), as we have the AutoWamth plugin right now. I was so free to add a new label (please update the description as you feel). |
Issue
Steps to reproduce
crash.log
(if applicable)crash.log
is a file that is automatically created when KOReader crashes. It cannormally be found in the KOReader directory:
koreader/
directory for Kindle.adds/koreader/
directory for Koboapplications/koreader/
directory for PocketbookPlease try to include the relevant sections in your issue description.
You can upload the whole
crash.log
file on GitHub by dragging anddropping it onto this textbox, or you can use one of these paste services.
Please don't forget to set a high expiration date if you do.
https://pastebin.com https://slexy.org https://paste2.org https://fpaste.org
http://ix.io https://paste.kde.org https://paste.debian.net.
The text was updated successfully, but these errors were encountered: