Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light warmth automatic adjustment, set time light stays at Max. warmth #5372

Closed
jlynton opened this issue Sep 13, 2019 · 13 comments
Closed

Light warmth automatic adjustment, set time light stays at Max. warmth #5372

jlynton opened this issue Sep 13, 2019 · 13 comments
Labels
enhancement solved The issue is solved. Details are described in the issue.

Comments

@jlynton
Copy link

jlynton commented Sep 13, 2019

  • KOReader version:
  • Device:

Issue

Steps to reproduce

crash.log (if applicable)

crash.log is a file that is automatically created when KOReader crashes. It can
normally be found in the KOReader directory:

  • koreader/ directory for Kindle
  • .adds/koreader/ directory for Kobo
  • applications/koreader/ directory for Pocketbook

Please try to include the relevant sections in your issue description.
You can upload the whole crash.log file on GitHub by dragging and
dropping it onto this textbox, or you can use one of these paste services.
Please don't forget to set a high expiration date if you do.
https://pastebin.com https://slexy.org https://paste2.org https://fpaste.org
http://ix.io https://paste.kde.org https://paste.debian.net.

@jlynton
Copy link
Author

jlynton commented Sep 13, 2019

I am using a Kobo Clara HD, but imagine this could be done for all readers with adjustable warmth fronlights.

When I set the frontlight's warmth to 'Auto', I can set the time at which it reaches the maximum warmth. After that time (23:00) the light starts to get whiter again and reaches maximum whiteness around 02:00. What I would really like is to be able to set the time when it reaches maximum warmth, AND set how many hours it will stay at maximum warmth, after which the light will progressively get cooler.

Would it be possible to add this in to KoReader?

@Frenzie
Copy link
Member

Frenzie commented Sep 13, 2019

Could you also include a link to the MR discussion?

@jlynton
Copy link
Author

jlynton commented Sep 13, 2019

Certainly, here it is, thanks!

https://www.mobileread.com/forums/showthread.php?t=322783

@Frenzie
Copy link
Member

Frenzie commented Sep 13, 2019

Looks like these lines:

-- Between 2-4h after bedtime, return to zero.
self.fl_warmth = math.max(100 - 50 * (22 - diff_time), 0)

@jlynton
Copy link
Author

jlynton commented Sep 13, 2019

i am no coder, but it looks like it would be simple to set it to stay at max warmth for longer (personally I would like 6-8 hours), but ideally there would be a user setting in the 'Frontlight' dialogue.

@Frenzie
Copy link
Member

Frenzie commented Sep 14, 2019

I think 22 is just 24 – 2, where 2 is the number of hours to keep the max value.

This function currently looks to be at risk of being tripled, see #5331. It should migrate to BasePowerD.

@pazos
Copy link
Member

pazos commented Sep 14, 2019

I think we have some time to migrate common code before merging #5331.

@Frenzie
Copy link
Member

Frenzie commented Sep 14, 2019

Volunteering? :-D

@AlanSP1
Copy link

AlanSP1 commented Sep 21, 2019

Just to add my two cents, it would be really nice option to have (i.e. option how many hours it stays at maximum). Also, there could be option how many hours it takes to "fade in/out" from min to max.

If there's none I mean. Because, I don't mess with light temperature myself, but I imagine that it would be pretty nice to have these two options:

  1. Time to stay at max value
  2. Time to reach or loose max value.

@gerhaher
Copy link

  1. Define max value (for those who don't like it to go to 100%)

@pazos
Copy link
Member

pazos commented Sep 21, 2019

Volunteering? :-D

For the refactor yeah! For this PR nope!. I will give it a look tomorrow

@AlanSP1
Copy link

AlanSP1 commented Sep 21, 2019

  1. Define max value (for those who don't like it to go to 100%)

Well, there can be also this one:

  1. Define min (i.e. starting) value.

I think these 4 options would cover all. :D

@zwim zwim added the solved The issue is solved. Details are described in the issue. label Mar 8, 2023
@zwim
Copy link
Contributor

zwim commented Mar 8, 2023

I think we might close this (and mark as solved), as we have the AutoWamth plugin right now.

I was so free to add a new label (please update the description as you feel).

@zwim zwim closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement solved The issue is solved. Details are described in the issue.
Projects
None yet
Development

No branches or pull requests

6 participants