Incorrect order of extracted highlights

[ichnilatis-gr]

• KOReader version: v2021.12.1
• Device: PB 628

Issue

Some times the extracted highlights don't follow the order of the highlights in the book. You can see this in the following screenshots. (Sorry that they are from a Greek book).

[hius07]

I guess the bookmark No 2 was added first on this page? (Check time)
Within one page bookmarks are sorted in order of adding them.
I agree that this should be fixed.

[ichnilatis-gr]

The highlights were made in the order they appear on the page (as they are numbered in the first screenshot).

[hius07]

Can you share a metadata.*.lua file of this book (it is in the .sdr folder that is near the book).

[ichnilatis-gr]

It's 1.26 MB and it seems difficult to be uploaded... :-)

[Frenzie]

The limit should be something like 10 MB. Maybe if you zip it?

[hius07]

There are no bookmarks in that file.

[ichnilatis-gr]

Excuse me, my false. Wrong file.

By the way, have a blessed year with good health!

[hius07]

Thank you for the file. I see that the bookmarks of page 261 are in good order.
I guess they are displayed in the Bookmark list in good order too.

It seems that the issue occurs in the Exporter plugin that tries to finally sort the list to be exported

koreader/plugins/exporter.koplugin/clip.lua

Line 286 in 6c9e222

table.sort(book, function(v1, v2) return v1[1].page < v2[1].page end)

taking into account page numbers only.
When page numbers of several elements are the same, we cannot get the correct order of the bookmarks of this page.

I'm now working on fixing the bookmark module to get bookmarks of one page correctly sorted depending on their position in the text (now they are sorted in order of adding).
If I succeed (hope so) I'll try to look into the plugin more closely, it would be easier to fix it based on the well sorted bookmarks list.

[ichnilatis-gr]

For some reason, after having installed the last nightly versions (v2021.12.1-29 and v2021.12.1-41), highlights are not extracted from the book given above as example. The process takes place, but I cannot find the file in the clipboard folder. This problem doesn't exist for other pdf files.

Any idea?

[Frenzie]

@NiLuJe mentioned a conversion might still be missing in current nightlies or something?

[NiLuJe]

That was an opds server added to the default list, IIRC, nothing to do with this ;).

[poire-z]

Fixed by #8616.

[ichnilatis-gr]

@hius07 , @Frenzie , @poire-z
I thought that this issue had been resolved, but today I noticed that it hasn't.
I give you (unfortunately for you in Greek) a page containing highlights and their view in the extracted file.
The order of the extracted highlights is the reverse of the order in the book.