How can I modify arrow of page overlap function?

[omer-faruq]

When I read PDFs with two columns page overlap function makes it better to read docs. I want to add some white and black border to arrow to make it more visible at first sight . Where can I find it? is it customizable? Is there a way to do this? Thanks .

[poire-z]

There is not setting for this in the menus, the icon and size are hardcoded.

Currently, you could just override the icon used (control.expand.alpha) with something different, which must be a SVG file, that you could drop in a (create this directoty) koreader/icons/ by giving it the name control.expand.alpha.svg.
It will still have the current small size.

koreader/frontend/apps/reader/modules/readerview.lua

Lines 114 to 120 in 5bcd3d0

	local arrow_size = Screen:scaleBySize(16)
	self.arrow = IconWidget:new{
	icon = "control.expand.alpha",
	width = arrow_size,
	height = arrow_size,
	alpha = true, -- Keep the alpha layer intact, the fill opacity is set at 75%
	}

Once #9104 is merged (soon), you could hack the above bit code that builds the thing to give it another name and size. Something like this, put in patches/2-my-overlap_arrow.lua could work:

local IconWidget = require("ui/widget/iconwidget")
local ReaderView = require("apps/reader/modules/readerview")
local addWidgets_orig = ReaderView.addWidgets
ReaderView:addWidgets = function(self)
    -- Run original code
    addWidgets_orig(self)
    local arrow_size = Screen:scaleBySize(16 * 2)
    self.arrow = IconWidget:new{
        icon = "the_name_of_my_svg_file",
        width = arrow_size,
        height = arrow_size,
        alpha = true, -- or false, if you don't want transparency with your big solid black icon
    }
end

[omer-faruq]

thanks for the reply, I'll try to modify the image control.expand.alpha , also the size.

[omer-faruq]

I made these modifications to the icon file: 1- increase size to 32*32 , 2- add some white space to above and below 3- fill background with solid white (only left part), 2- made arrow %100 black.

modified the code to be able to use the icon with size 32 (as descirbed above)
( also created the user patch file )

[poire-z]

also created the user patch file

Feel free to share its code here :)

[omer-faruq]

Oh, I mean with the code you already shared
( didn't test it yet )

[poire-z]

Oh, right, I posted some code :) I haven't tested it, I see that it is missing something at top:
local Screen = require("device").screen
(still not tested :)

[omer-faruq]

To test the user patches I switched to Developer Upgrade mode, Now when It restarts it says:

Error appying patch:
 ./patches/2-overlap_arror_32.lua 

Unfortunately I don't know how to look at the error logs if any.

[poire-z]

there should be a file koreader/crash.log in which there may be more details (it's actually just the full log)

[omer-faruq]

It says:
WARN Patching failed: ./patches/2-overlap_arrow_32.lua:5: function arguments expected near '='

5th line:
ReaderView:addWidgets = function(self)

I didn't get the reason of error, if you have an idea I can try :)

[poire-z]

Right. Replace this : with ., beween ReaderView and addWidgets
ReaderView.addWidgets = function(self)

[omer-faruq]

Yes this fixed the problem, thanks appreciated your help on this.

Here is the working patch:

2-overlap_arrow_32.lua.txt