Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker/Android: bump TC creation #40

Merged
merged 3 commits into from Jul 2, 2019
Merged

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Jun 28, 2019

@pazos
Copy link
Member

pazos commented Jul 1, 2019

Looking the last failed build https://gitlab.com/koreader/nightly-builds/-/jobs/242868508 it seems that purging unused abis has no impact in launcher (which has restricted ndk abis in its build.gradle) but has impact in einkTest (which has no arch dependant code, but it is targeted as an universal apk)

We can restrict einkTest to armeabi-v7a since it is used on all eink devices out there or just leave the ndk without pruning.

@pazos
Copy link
Member

pazos commented Jul 1, 2019

Is ANDROID_HOME pointing to the sdk root folder? If not
echo 'export ANDROID_HOME=/home/ko/android-sdk-linux' >>./.bashrc

@Frenzie
Copy link
Member Author

Frenzie commented Jul 1, 2019

@pazos There is no last failed build per se. It's still pending, and has been for a few hours. (Business hours aren't good for the free plan. ;-D)

https://gitlab.com/koreader/nightly-builds/-/jobs/243118786

But indeed, it shouldn't matter. I think restricting eInktest is the way to go.

just leave the ndk without pruning.

Meh, that's more than twice as large for no good reason.

@Frenzie
Copy link
Member Author

Frenzie commented Jul 2, 2019

@pazos It still seems to be trying to access it? Do I have to comment out the pruning? :-/

@Frenzie
Copy link
Member Author

Frenzie commented Jul 2, 2019

PS NDK r17 removes that specific arch https://developer.android.com/ndk/guides/abis#sa

@pazos
Copy link
Member

pazos commented Jul 2, 2019

Create fake dir to silence gradle complaint

🤦‍♂️

@Frenzie
Copy link
Member Author

Frenzie commented Jul 2, 2019

But it works! 🤣

@Frenzie Frenzie merged commit 4b6d569 into koreader:master Jul 2, 2019
@Frenzie Frenzie deleted the android-update branch July 2, 2019 16:59
Frenzie added a commit to Frenzie/koreader-base that referenced this pull request Jul 3, 2019
Frenzie added a commit to koreader/koreader-base that referenced this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants