Allow install scripts to be used by koreader CI #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yparitcher
force-pushed
the
master
branch
3 times, most recently
from
2b2de72
to
83e6fe2
Compare
|
Please review |
Frenzie
reviewed
Dec 31, 2021
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Dec 31, 2021
Use latest busted dont install luacov-coveralls & luasec: we don't use them at all There is no need to explicitly install dependencies
|
Closes: #70 |
Closed
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Jan 2, 2022
|
Btw, I just realized luasec was probably in there because the sync server came first. Cross-ref to koreader/koreader#8607 |
Frenzie
reviewed
Apr 15, 2022
| @@ -1,30 +1,11 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| HOME=/home/ko | |||
| apt-get install --no-install-recommends luarocks | |||
There was a problem hiding this comment.
@yparitcher This cannot have ever worked, can it?
There was a problem hiding this comment.
No, it cannot.
If we want to use distro luarocks, it should be done in https://github.com/koreader/virdevenv/blob/11b62a5722b3adc1d98ce8484b89968b136db4c5/docker/ubuntu/baseimage/bootstrap.sh really
But you could do it here with sudo in theory, see
Keep in mind we purposefully remove the apt cache lines earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of work to also use Github actions as CI
Use distro luarocks
Install packages globally
Use latest busted
Dont install luacov-coveralls & luasec: we don't use them at all
There is no need to explicitly install luarocks dependencies
This change is