-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for postgis database #221
Conversation
@asherf Why does the test_cache.py fail? Could you help me with it. I'm really keen to resolve this one, and by the looks of it, it is a commonly requested feature. Can't connect to redis-- but why? Any insight would be appreciated. |
I'll take a look at the redis failure later this week. |
@EverWinter23 can you try rebasing and re-pushing ? |
@EverWinter23 I also merged #218
|
@asherf Thanks! I'll take a look. |
@asherf Yay!!! Almost there failing for Update: Linting error 🤦 |
@asherf Fails for |
Finally!!! |
@asherf Ready for review. |
class DatabaseFeatures(base.DatabaseFeatures): | ||
"""Our database has the exact same features as the base one.""" | ||
|
||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed.
See https://help.semmle.com/wiki/display/PYTHON/Unnecessary+pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Why is it there in mysql/base.py
and postgresql/base.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this block.
lgtm, minus the nitpick comment. |
thanks for adding this feature! |
No problem. Needed it badly. |
This adds support for PostGis database which is
also supported officially by django-- geodjango.
Refrences: #41 #90 #140