Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phploc and phpmetrics #43

Closed
wants to merge 2 commits into from
Closed

Add phploc and phpmetrics #43

wants to merge 2 commits into from

Conversation

kenjis
Copy link
Contributor

@kenjis kenjis commented Oct 7, 2018

I always use phploc and phpmetrics.
So I hope new PHP projects have them.

@koriym
Copy link
Owner

koriym commented Oct 9, 2018

Feel free to do PR in bear/qatools as well.
https://github.com/bearsunday/BEAR.QATools

I exclude phploc from skeleton because it is like more for CI tools? (like document generator)
or you may need those tools at development. Thoughts?

@kenjis
Copy link
Contributor Author

kenjis commented Oct 10, 2018

I sent PR: bearsunday/BEAR.QATools#9

I exclude phploc from skeleton because it is like more for CI tools? (like document generator)
or you may need those tools at development. Thoughts?

I see code size (LOC or xLOC) at development.
But yeah, it is also QA tool and is like more for CI tools.

@koriym
Copy link
Owner

koriym commented Oct 11, 2018

Thank you for the PR. Merged.

@koriym
Copy link
Owner

koriym commented Oct 11, 2018

About LOC, still not sure ... 🤔

@koriym
Copy link
Owner

koriym commented Jan 14, 2019

@kenjis I close this issue, feel free to reopen when you need.

@koriym koriym closed this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants