Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phpunit.xml #69

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Update phpunit.xml #69

merged 3 commits into from
Mar 18, 2021

Conversation

kenjis
Copy link
Contributor

@kenjis kenjis commented Mar 16, 2021

  • migrate phpunit.xml.dist to PHPUnit 9.3 format
  • add path coverage

@koriym
Copy link
Owner

koriym commented Mar 16, 2021

./build/cache/coverageよりは他はルートにキャッシュするのに合わせて.phpunit.cache/code-coverageにしましょうか？

参考：
https://github.com/search?o=desc&q=coverage+cacheDirectory+filename%3Aphpunit.xml.dist&s=indexed&type=Code

@kenjis
chore: change cacheDirectory
4002b20 
The others are cached in the root, so match them.
@kenjis
Copy link
Contributor Author

kenjis commented Mar 17, 2021

Done!

@koriym koriym merged commit b7f6d11 into koriym:1.x Mar 18, 2021
@koriym
Copy link
Owner

koriym commented Mar 18, 2021

Released as 1.1.11! https://github.com/koriym/Koriym.PhpSkeleton/releases/tag/1.1.11

@kenjis kenjis deleted the update-phpunit.xml branch March 18, 2021 03:41
@kenjis kenjis mentioned this pull request Jul 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenjis @koriym