-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallible actions support #73
Conversation
Alright, #75 is now merged, so feel free to integrate that into your PR :) |
@dkumsh Did you intentionally close this PR? I think the changes would still be nice :) |
@ryan-summers I think I closed it unintentionally. I am re-opening this PR after rebasing on master. As we agreed on the guards, I keep the change as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
As discussed at #44
Fixes #44
This PR has 3 commits:
&mut self
->&self
)