Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallible actions support #73

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Fallible actions support #73

merged 3 commits into from
Jul 2, 2024

Conversation

dkumsh
Copy link

@dkumsh dkumsh commented Jun 27, 2024

As discussed at #44

Fixes #44

This PR has 3 commits:

  • add fallible actions support
  • disallow guards mutating context/state (&mut self -> &self)
  • rename GuardError to TypeError as it is now used not only by the guards, but also by the actions

CHANGELOG.md Outdated Show resolved Hide resolved
examples/dominos.rs Outdated Show resolved Hide resolved
examples/named_dominos.rs Outdated Show resolved Hide resolved
macros/src/codegen.rs Show resolved Hide resolved
macros/src/codegen.rs Outdated Show resolved Hide resolved
@ryan-summers
Copy link
Collaborator

@dkumsh I'm refactoring internal state management in #76 to prevent the "State is None problem, which will simplify this a lot. If you want to wait until that PR gets merged and then rebase/merge, that would probably be easiest.

@dkumsh
Copy link
Author

dkumsh commented Jul 1, 2024

@dkumsh I'm refactoring internal state management in #76 to prevent the "State is None problem, which will simplify this a lot. If you want to wait until that PR gets merged and then rebase/merge, that would probably be easiest.

Thanks, totally makes sense. Will wait. Please let me know.

@ryan-summers
Copy link
Collaborator

Alright, #75 is now merged, so feel free to integrate that into your PR :)

@ryan-summers
Copy link
Collaborator

@dkumsh Did you intentionally close this PR? I think the changes would still be nice :)

@dkumsh
Copy link
Author

dkumsh commented Jul 2, 2024

@ryan-summers I think I closed it unintentionally.

I am re-opening this PR after rebasing on master.

As we agreed on the guards, I keep the change as well.

@dkumsh dkumsh reopened this Jul 2, 2024
@dkumsh dkumsh requested a review from ryan-summers July 2, 2024 15:55
Copy link
Collaborator

@ryan-summers ryan-summers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ryan-summers ryan-summers merged commit 6a2188c into korken89:master Jul 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fallible actions support
2 participants