Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add ability to automatically add -sources.jar file for locally built Korge version that's published to mavenLocal. #44

Closed
Kietyo opened this issue Aug 27, 2022 · 7 comments
Assignees

Comments

@Kietyo
Copy link
Contributor Author

Kietyo commented Aug 27, 2022

@soywiz
Copy link
Member

soywiz commented Aug 29, 2022

Thanks for the details! Let's see if we can do something. In any case if we manage to use the plugin to fix this, would be nice to also make a PR to fix it in IDEA itself

@Kietyo
Copy link
Contributor Author

Kietyo commented Aug 30, 2022

Abe (the person who created a plugin to fix this issue themselves) generously shared their code:

https://youtrack.jetbrains.com/issue/IDEA-227215/Maven-local-repo-sources-not-imported-in-Idea-libraries-after-Gradle-6-update#focus=Comments-27-6417980.0-0

https://gist.github.com/hamoid/2438191187526e1c5dabced31bba9b38

@Kietyo
Copy link
Contributor Author

Kietyo commented Aug 30, 2022

I don't seem to have permissions to assign this issue to myself.

Feel free to assign to me, I can try taking this on.

@hamoid
Copy link

hamoid commented Aug 30, 2022

If there are questions I can try to answer :-) I hope the comments I added to the code help a bit.

@Kietyo
Copy link
Contributor Author

Kietyo commented Sep 3, 2022

Thanks Abe, it was very useful. Here's the solution I came up with:

#45

@soywiz
Copy link
Member

soywiz commented Oct 11, 2022

This was already merged and available in the intellij plugin

@soywiz soywiz closed this as completed Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants