Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

[Fix] Updated BitSet to use all 32 bits of an Int #179

Merged
merged 1 commit into from Feb 27, 2021
Merged

[Fix] Updated BitSet to use all 32 bits of an Int #179

merged 1 commit into from Feb 27, 2021

Conversation

andrei-cosmin
Copy link
Contributor

@andrei-cosmin andrei-cosmin commented Feb 27, 2021 •
edited

No description provided.

@andrei-cosmin
BitSet uses the full 32 bits of an Int
fb851f7 
data field is now private to prevent potential leaks
@andrei-cosmin andrei-cosmin changed the title [Fix] BitSet [Fix] Updated BitSet to use all 32 bits of an Int Feb 27, 2021
@soywiz soywiz merged commit 7174868 into korlibs-archive:master Feb 27, 2021
@soywiz
Copy link
Contributor

soywiz commented Feb 27, 2021

Thanks @andrei-cosmin !

nibble

4bits

@soywiz
Copy link
Contributor

soywiz commented Feb 27, 2021 •
edited

In this codebase there is no external usage of the data properly and hope nobody else is using it, so I guess it is ok to make it private.
Maybe we could provide a copyTo and clone methods that use this array to perform a fast copy that doesn't require copying bit by bit, in the case someone needs to duplicate it fast

@andrei-cosmin andrei-cosmin deleted the patch-1 branch March 6, 2021 10:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrei-cosmin @soywiz