#336: Update core/insert to more accurately reflect hash created by MSSQL #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Problem
The docstring for
korma.core/insert
implies that the hash returned by MSSQL is{:generated_key <ID>}
instead of #336 's reported{:generated_keys <ID>}
.Proposed Solution
Update the docstring to explicitly state that MSSQL returns a hash of
{:generated_keys <ID>}
.Endpoint
korma.core/insert
docstring accurately describes MSSQL's hash structure.Changes