Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#336: Update core/insert to more accurately reflect hash created by MSSQL #375

Merged
merged 1 commit into from Feb 12, 2017

Conversation

rpazyaquian
Copy link
Contributor

Original Problem

The docstring for korma.core/insert implies that the hash returned by MSSQL is {:generated_key <ID>} instead of #336 's reported {:generated_keys <ID>}.

Proposed Solution

Update the docstring to explicitly state that MSSQL returns a hash of {:generated_keys <ID>}.

Endpoint

korma.core/insert docstring accurately describes MSSQL's hash structure.

Changes

@rpazyaquian
Copy link
Contributor Author

This is my first contribution to the project. Please let me know if there is any particular process or guidelines I should follow.

@immoh immoh merged commit afebaa1 into korma:master Feb 12, 2017
@immoh
Copy link
Member

immoh commented Feb 12, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants