Fix --separate-debug-symbols #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously cargo-deb attempted to add the files with debug symbols by referencing the stripped executable path. The debug symbols do not live alongside the stripped executables so this always failed. Now cargo-deb uses the original executable paths to determine the location of the debug symbols. (There's probably a better way to do this, but I'm not skilled enough to figure out how to use collect() with the parallel iterator.)
|
Is it possible to write a test for it? It's likely I'll break it again otherwise. |
|
I'll try! |
All build the cargo deb the same way, so make it reusable in future tests.
drbrain
force-pushed
the
fix-separate-debug-symbols
branch
from
d8bc217
to
1a2a49d
Compare
|
Thank you |
|
Actual test added in #83, sorry! 🙇🏻♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously cargo-deb attempted to add the files with debug symbols by referencing the stripped executable path. The debug symbols do not live alongside the stripped executables so this always failed.
Now cargo-deb uses the original executable paths to determine the location of the debug symbols.
(There's probably a better way to do this, but I'm not skilled enough to figure out how to use collect() with the parallel iterator.)