Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing malloc fail check in read_chunk_callback #408

Closed
void0red opened this issue Jul 21, 2023 · 1 comment
Closed

missing malloc fail check in read_chunk_callback #408

void0red opened this issue Jul 21, 2023 · 1 comment

Comments

@void0red
Copy link

we perform a test on pngquant and find two bugs in read_chunk_callback.

struct rwpng_chunk *chunk = malloc(sizeof(struct rwpng_chunk));

chunk->data = in_chunk->size ? malloc(in_chunk->size) : NULL;

it may cause NPD later since malloc fails when oom.

kornelski added a commit that referenced this issue Jul 21, 2023
@kornelski
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants