Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Quaternion api #1747

Closed
edgarriba opened this issue Jun 17, 2022 · 0 comments 路 Fixed by #1801
Closed

add Quaternion api #1747

edgarriba opened this issue Jun 17, 2022 · 0 comments 路 Fixed by #1801
Assignees
@edgarriba
Labels
feature request New feature or request help wanted Extra attention is needed module: geometry

Comments

@edgarriba
Copy link
Member

edgarriba commented Jun 17, 2022 •
edited

馃殌 Feature

Add Quaternion class that is compatible with Eigen::Quaternion
https://eigen.tuxfamily.org/dox/classEigen_1_1Quaternion.html

Initial implementation here: https://github.com/kornia/kornia/blob/liegroup-algebra/kornia/geometry/liegroup/quaternion.py

Motivation

We want a simple api that can be easily combined with kornia.geometry.conversions and the upcoming kornia.geometry.liegroup

TBD: where this api should live

Consider also to contribute to Kornia universe projects :)

  • Tutorials: our repository containing the tutorials.
@edgarriba edgarriba added help wanted Extra attention is needed feature request New feature or request module: geometry labels Jun 17, 2022
@edgarriba edgarriba self-assigned this Jun 17, 2022
@edgarriba edgarriba mentioned this issue Jul 23, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgarriba edgarriba

Labels
feature request New feature or request help wanted Extra attention is needed module: geometry
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Quaternion API kornia/kornia
1 participant
@edgarriba