Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Quaternion API #1801

Merged
merged 7 commits into from Aug 18, 2022
Merged

Add Quaternion API #1801

merged 7 commits into from Aug 18, 2022

Conversation

edgarriba
Copy link
Member

Changes

Fixes #1747

Type of change

  • 馃摎 Documentation Update
  • 馃И Tests Cases
  • 馃悶 Bug fix (non-breaking change which fixes an issue)
  • 馃敩 New feature (non-breaking change which adds functionality)
  • 馃毃 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 馃摑 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@edgarriba edgarriba changed the title Add quaternion API Add Quaternion API Jul 26, 2022
@edgarriba edgarriba marked this pull request as ready for review July 26, 2022 20:48
@edgarriba
Copy link
Member Author

@amonszpart heads up as for previous work on that. Feedback is welcomed.

@edgarriba edgarriba mentioned this pull request Aug 12, 2022
Merged
9 tasks
@edgarriba
Copy link
Member Author

@ducha-aiki please review towards new pose / 3d api design

@edgarriba edgarriba mentioned this pull request Aug 14, 2022
Closed
ducha-aiki
ducha-aiki approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@ducha-aiki ducha-aiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ducha-aiki ducha-aiki merged commit 451f640 into master Aug 18, 2022
@ducha-aiki ducha-aiki deleted the feat-quaternion branch August 18, 2022 12:27
ducha-aiki pushed a commit that referenced this pull request Aug 18, 2022
@edgarriba @ducha-aiki
Add Quaternion API (#1801)
4430b3f 
* Quaternion API
@renovate renovate bot mentioned this pull request Sep 1, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducha-aiki ducha-aiki ducha-aiki approved these changes

@shijianjian shijianjian Awaiting requested review from shijianjian

@lferraz lferraz Awaiting requested review from lferraz

Assignees
No one assigned
Labels
feature request New feature or request module: geometry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add Quaternion api
2 participants
@edgarriba @ducha-aiki