Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimal Triangulation #2739

Open
Parskatt opened this issue Jan 18, 2024 · 2 comments
Open

Optimal Triangulation #2739

Parskatt opened this issue Jan 18, 2024 · 2 comments
Labels
enhancement 馃殌 Improvement over an existing functionality help wanted Extra attention is needed module: geometry

Comments

@Parskatt
Copy link
Contributor

馃殌 Feature

Currently kornia supports linear triangulation, adding optimal triangulation would make kornia more viable for triangulation of points from correspondences.

Motivation

Optimal triangulation is better than non-optimal triangulation.

Additional context

Heres the colmap implementation:
https://github.com/colmap/colmap/blob/fb3fa6a6962f8fee299d03b895cac2e1dd052104/src/colmap/geometry/triangulation.cc#L92

I might adapt this to kornia and submit PR

@Parskatt Parskatt added the help wanted Extra attention is needed label Jan 18, 2024
@Parskatt
Copy link
Contributor Author

@edgarriba
Copy link
Member

@Parskatt this is definitely a good feature to add. Feel to add any of these methods, all seem useful

@edgarriba edgarriba added enhancement 馃殌 Improvement over an existing functionality module: geometry labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 馃殌 Improvement over an existing functionality help wanted Extra attention is needed module: geometry
Projects
None yet
Development

No branches or pull requests

2 participants