New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unsharp mask filtering #1004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarriba
added
enhancement 🚀
Improvement over an existing functionality
1 Priority 1 🚨
High priority
module: filters
labels
May 13, 2021
edgarriba
requested review from
anguelos,
ducha-aiki,
lferraz and
shijianjian
as code owners
May 13, 2021 18:48
@AnimeshMaheshwari22 thanks for your first contribution !! |
Thank you for the constant guidance and support! |
edgarriba
added a commit
that referenced
this pull request
May 30, 2021
* Added functionality for unsharp mask * Added functionality for Unsharp Mask * Implemented the changes to Unsharp Mask functionality * fix linter and jit test * add unsharp to docs * update python version in gh actions format Co-authored-by: AnimeshMaheshwari22 <animesh.m2202@gmail.com> Co-authored-by: AnimeshMaheshwari22 <45392539+AnimeshMaheshwari22@users.noreply.github.com>
edgarriba
added a commit
to edgarriba/kornia
that referenced
this pull request
Jul 6, 2021
* Added functionality for unsharp mask * Added functionality for Unsharp Mask * Implemented the changes to Unsharp Mask functionality * fix linter and jit test * add unsharp to docs * update python version in gh actions format Co-authored-by: AnimeshMaheshwari22 <animesh.m2202@gmail.com> Co-authored-by: AnimeshMaheshwari22 <45392539+AnimeshMaheshwari22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1 Priority 1 🚨
High priority
enhancement 🚀
Improvement over an existing functionality
module: filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
continuation of #999
Status
Ready/Work in progress/Hold
Types of changes
PR Checklist
PR Implementer
This is a small checklist for the implementation details of this PR.
If there are any questions regarding code style or other conventions check out our
summary.
make test
make build-docs
make lint
make mypy
KorniaTeam
KorniaTeam workflow
closes #IssueNumber
at the bottom ifnot already in description)
Reviewer
Reviewer workflow
kornia
design conventions?