Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unsharp mask filtering #1004

Merged
merged 7 commits into from May 13, 2021
Merged

Added unsharp mask filtering #1004

merged 7 commits into from May 13, 2021

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented May 13, 2021

Description

continuation of #999

Status

Ready/Work in progress/Hold

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.

If there are any questions regarding code style or other conventions check out our
summary.

  • Did you discuss the functionality or any breaking changes before ?
  • Pass all tests: did you test in local ? make test
  • Unittests: did you add tests for your new functionality ?
  • Documentations: did you build documentation ? make build-docs
  • Implementation: is your code well commented and follow conventions ? make lint
  • Docstrings & Typing: has your code documentation and typing ? make mypy
  • Update notebooks & documentation if necessary

KorniaTeam

KorniaTeam workflow
  • Assign correct label
  • Assign PR to a reviewer
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, Typing, Linting, Documentation, Environment)
  • Does the implementation follow kornia design conventions?
  • Is the documentation complete enough ?
  • Are the tests covering simple and corner cases ?

@edgarriba edgarriba added enhancement 🚀 Improvement over an existing functionality 1 Priority 1 🚨 High priority module: filters labels May 13, 2021
@edgarriba edgarriba changed the title Unsharp mask contribution Added unsharp mask filtering May 13, 2021
@edgarriba edgarriba merged commit 020b63d into master May 13, 2021
@edgarriba edgarriba deleted the UnsharpMask-contribution branch May 13, 2021 19:50
@edgarriba
Copy link
Member Author

@AnimeshMaheshwari22 thanks for your first contribution !!

@AnimeshMaheshwari22
Copy link
Contributor

@AnimeshMaheshwari22 thanks for your first contribution !!

Thank you for the constant guidance and support!

edgarriba added a commit that referenced this pull request May 30, 2021
* Added functionality for unsharp mask

* Added functionality for Unsharp Mask

* Implemented the changes to Unsharp Mask functionality

* fix linter and jit test

* add unsharp to docs

* update python version in gh actions format

Co-authored-by: AnimeshMaheshwari22 <animesh.m2202@gmail.com>
Co-authored-by: AnimeshMaheshwari22 <45392539+AnimeshMaheshwari22@users.noreply.github.com>
edgarriba added a commit to edgarriba/kornia that referenced this pull request Jul 6, 2021
* Added functionality for unsharp mask

* Added functionality for Unsharp Mask

* Implemented the changes to Unsharp Mask functionality

* fix linter and jit test

* add unsharp to docs

* update python version in gh actions format

Co-authored-by: AnimeshMaheshwari22 <animesh.m2202@gmail.com>
Co-authored-by: AnimeshMaheshwari22 <45392539+AnimeshMaheshwari22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Priority 1 🚨 High priority enhancement 🚀 Improvement over an existing functionality module: filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants