Add PadTo to kornia.augmentation #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarriba
requested review from
ducha-aiki,
lferraz and
shijianjian
as code owners
for more information, see https://pre-commit.ci
|
@shijianjian I did the skeleton - please check about some of the details. Also not sure about how to test the AugmentationSequential. |
shijianjian
reviewed
Sep 14, 2021
shijianjian
requested changes
Sep 14, 2021
Co-authored-by: Jian Shi <sj8716643@126.com>
for more information, see https://pre-commit.ci
edgarriba
commented
Sep 16, 2021
| def compute_transformation(self, image: torch.Tensor, params: Dict[str, torch.Tensor]) -> torch.Tensor: | ||
| return self.identity_matrix(image) | ||
|
|
||
| def apply_transform( | ||
| self, image: torch.Tensor, params: Dict[str, torch.Tensor], transform: Optional[torch.Tensor] = None | ||
| self, input: torch.Tensor, params: Dict[str, torch.Tensor], transform: Optional[torch.Tensor] = None |
There was a problem hiding this comment.
the function signature will need to align with the parent class. If you gonna work on it, I would suggest to do it at once, not for one or two functions for consistency. Also, please keep in mind about the deprecation warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1283
Type of change
Checklist