Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common bbox format xywh in DataKey #1472

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Use common bbox format xywh in DataKey #1472

merged 1 commit into from
Nov 30, 2021

Conversation

twsl
Copy link
Contributor

@twsl twsl commented Nov 29, 2021

Changes

Fixes #1471

Type of change

  • 馃悶 Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@edgarriba
Copy link
Member

@shijianjian

@shijianjian
Copy link
Member

@twsl You need to deprecate the previous data key than replace it. Otherwise, it may crash other users' code.

@twsl
Copy link
Contributor Author

twsl commented Nov 29, 2021

@shijianjian I have no idea how to do that.
And I don't think anyone is using the key name directly because you'd have to use undocumented features rather than fixing the bug.

@edgarriba edgarriba merged commit 155b73f into kornia:master Nov 30, 2021
@twsl twsl deleted the fix/datakey branch November 30, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataKey Typo BBOX_XYHW
3 participants