Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/quaternion #155

Merged
merged 6 commits into from
Jun 18, 2019
Merged

Feat/quaternion #155

merged 6 commits into from
Jun 18, 2019

Conversation

edgarriba
Copy link
Member

No description provided.

@edgarriba edgarriba requested review from Mona77, amayeh and bhack June 4, 2019 15:31
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #155 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #155     +/-   ##
=========================================
+ Coverage   96.38%   96.48%   +0.1%     
=========================================
  Files          49       49             
  Lines        1659     1709     +50     
=========================================
+ Hits         1599     1649     +50     
  Misses         60       60
Impacted Files Coverage Δ
kornia/geometry/camera/pinhole.py 73.83% <ø> (-0.13%) ⬇️
kornia/geometry/conversions.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f45f5...662b13a. Read the comment docs.

return quaternion_exp


def quaternion_exp_to_log(quaternion: torch.Tensor,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhack @lenlen can you review this ? the test_gradcheck is crashing. Any clue ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check if the is something wrong in the pytorchfication?

@edgarriba edgarriba merged commit ab0ff96 into master Jun 18, 2019
@edgarriba edgarriba deleted the feat/quaternion branch June 26, 2019 15:57
edgarriba added a commit that referenced this pull request May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants