Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image API #1562

Merged
merged 47 commits into from Jul 16, 2023
Merged

Add Image API #1562

merged 47 commits into from Jul 16, 2023

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Feb 6, 2022

Changes

Fixes # (issue)

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

kornia/core/image.py Outdated Show resolved Hide resolved
kornia/core/image.py Outdated Show resolved Hide resolved
kornia/core/image.py Outdated Show resolved Hide resolved
@edgarriba edgarriba marked this pull request as ready for review February 26, 2022 08:51
@edgarriba edgarriba added feature request New feature or request module: core labels Feb 26, 2022
kornia/core/image.py Outdated Show resolved Hide resolved
@edgarriba edgarriba added the 1 Priority 1 🚨 High priority label Feb 27, 2022
@edgarriba
Copy link
Member Author

@twsl @Borda @shijianjian @ducha-aiki @lferraz please, last review before I merge

kornia/color/gray.py Outdated Show resolved Hide resolved
kornia/core/image.py Outdated Show resolved Hide resolved
kornia/core/image.py Outdated Show resolved Hide resolved
kornia/core/image.py Outdated Show resolved Hide resolved
@edgarriba edgarriba mentioned this pull request Oct 29, 2022
12 tasks
kornia/core/image.py Outdated Show resolved Hide resolved
kornia/color/gray.py Outdated Show resolved Hide resolved
kornia/image/image.py Outdated Show resolved Hide resolved
kornia/image/image.py Outdated Show resolved Hide resolved
kornia/image/image.py Outdated Show resolved Hide resolved
test/image/test_image.py Outdated Show resolved Hide resolved
test/io/test_io_image.py Outdated Show resolved Hide resolved
kornia/image/image.py Outdated Show resolved Hide resolved
@cjpurackal
Copy link
Member

One function that I think is useful is coords() -> List that'll return the u,v coordinates. ( I can add it later)

@edgarriba
Copy link
Member Author

One function that I think is useful is coords() -> List that'll return the u,v coordinates. ( I can add it later)

it will be the same as creating a meshgrid ?

@cjpurackal
Copy link
Member

One function that I think is useful is coords() -> List that'll return the u,v coordinates. ( I can add it later)

it will be the same as creating a meshgrid ?

Yes.

kornia/image/base.py Outdated Show resolved Hide resolved
edgarriba and others added 2 commits July 16, 2023 09:13
Co-authored-by: Christie Jacob <christeejacobs@gmail.com>
@edgarriba edgarriba merged commit 34017fc into master Jul 16, 2023
21 checks passed
@edgarriba edgarriba deleted the feat/image_api branch July 16, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Priority 1 🚨 High priority feature request New feature or request module: core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants