Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SOLD2 line detector / matcher #1844

Merged
merged 29 commits into from Aug 30, 2022
Merged

Add SOLD2 line detector / matcher #1844

merged 29 commits into from Aug 30, 2022

Conversation

ducha-aiki
Copy link
Member

@ducha-aiki ducha-aiki commented Aug 30, 2022 •
edited

Changes

Replaces #1507

Fixes # (issue)

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

rpautrat and others added 28 commits December 23, 2021 21:10
@rpautrat
Added SOLD2 line detector
675c7bf
@rpautrat
Added tests for SOLD2 detector
d98a148
@rpautrat
Added full SOLD2 model for line matching
5b73c13
@rpautrat
Added tests for SOLD2 descriptor
653b7fe
@rpautrat
Fixed warning in grid_sample
30d015d
@rpautrat
Added documentation for SOLD2
5068f5b
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b60211f 
for more information, see https://pre-commit.ci
@rpautrat
Various fixes for pre-commit and DeepSource
8935093
@rpautrat
Fix pre-commit for test_sold2.py
e1394f5
@rpautrat
Fixed merge conflict in sold2_detector.py
d7c3424
@rpautrat
Fixed DeepSource issues for SOLD2
8fea931
Fetch upstream changes
f860a08
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
305634c 
for more information, see https://pre-commit.ci
Fixed typing issues and comments for PR
40e94f9
Solved merge conflicts
ca8fe3a
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0fe79b6 
for more information, see https://pre-commit.ci
@rpautrat
Moved all Numpy function to Pytorch
d3a4349
@rpautrat
Formatting and test update
0c0fda9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3f370f1 
for more information, see https://pre-commit.ci
@rpautrat
Remove assert and dangerous arguments
0c9a2ea
@rpautrat
Flake8 fix
eaeeede
@rpautrat @edgarriba
Update kornia/feature/sold2/sold2.py
1e3ba46 
Remove cast to float before normalize_pixel_coordinates

Co-authored-by: Edgar Riba <edgar.riba@gmail.com>
@rpautrat
Fixed relative imports and removed dependency to torchvision
6a39587
@rpautrat
Fixed meshgrid issue with torch version + removed OrderedDict + no NM…
a445975 
…S is no junction detected
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
93ac36f 
for more information, see https://pre-commit.ci
@ducha-aiki
Added shape checks, lint
cf8409f
@ducha-aiki
Merge branch 'master' into sold2
d379ac9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e78512d 
for more information, see https://pre-commit.ci
edgarriba
edgarriba approved these changes Aug 30, 2022
View reviewed changes
kornia/feature/sold2/sold2.py Outdated Show resolved Hide resolved
@edgarriba edgarriba changed the title SOLD2 Add SOLD2 line detector / matcher Aug 30, 2022
@edgarriba edgarriba added feature request New feature or request module: feature labels Aug 30, 2022
@ducha-aiki ducha-aiki merged commit 3d7a6b4 into master Aug 30, 2022
@ducha-aiki ducha-aiki deleted the sold2 branch August 30, 2022 12:22
This was referenced Aug 30, 2022
Closed
Closed
@renovate renovate bot mentioned this pull request Sep 1, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarriba edgarriba edgarriba approved these changes

Assignees
No one assigned
Labels
feature request New feature or request module: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ducha-aiki @edgarriba @rpautrat