Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

facedetector now returns a list of tensors containing the boxes x image #2034

Merged
merged 4 commits into from Nov 29, 2022

Conversation

lferraz
Copy link
Member

@lferraz lferraz commented Nov 27, 2022

Changes

Now the FaceDetector returns lists of tensors instead of a tensor. It returns a list because not in all the images the number of boxes is the same.

Fixes # (issue)
When passing batches to the face detector the code failed because was partially not ready to support them.

Type of change

  • 馃摎 Documentation Update
  • 馃И Tests Cases
  • 馃悶 Bug fix (non-breaking change which fixes an issue)
  • 馃敩 New feature (non-breaking change which adds functionality)
  • 馃毃 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 馃摑 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a quick test to validate i/o shapes?

@lferraz
Copy link
Member Author

lferraz commented Nov 28, 2022

can you add a quick test to validate i/o shapes?

I improved one existing tests adding batches and some shape checks but it is not as simple as other ops.

Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor changes

kornia/contrib/face_detection.py Outdated Show resolved Hide resolved
kornia/contrib/face_detection.py Outdated Show resolved Hide resolved
kornia/contrib/face_detection.py Outdated Show resolved Hide resolved
test/test_contrib.py Outdated Show resolved Hide resolved
@lferraz lferraz force-pushed the allow_batches_with_facedetector branch from d89e95f to 8b3ca54 Compare November 29, 2022 09:15
@lferraz lferraz merged commit 7c36635 into master Nov 29, 2022
@lferraz lferraz deleted the allow_batches_with_facedetector branch November 29, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants