New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding LightGlue #2436
Adding LightGlue #2436
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any demo or tutorial update would be nice for later. Is this the kinda last top model or still Loftr is the thing ?
|
||
|
||
class LightGlueMatcher(GeometryAwareDescriptorMatcher): | ||
"""LightGlue-based matcher in kornia API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""LightGlue-based matcher in kornia API. | |
"""LightGlue-based matcher in kornia API. | |
Loftr is still the thing, however, on some images LG is better and it definitely much faster. |
would be great to update the tutorials or image matching page to explain when every model we have is useful |
and probably merge the most of image matching tutorials into single one, explaining the differences. |
Closing in favour of #2449 |
Changes
Adds LightGlue.
Type of change
Checklist