Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LightGlue #2436

Closed
wants to merge 5 commits into from
Closed

Adding LightGlue #2436

wants to merge 5 commits into from

Conversation

ducha-aiki
Copy link
Member

Changes

Adds LightGlue.

Type of change

  • 馃摎 Documentation Update
  • 馃И Tests Cases
  • 馃敩 New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@ducha-aiki ducha-aiki requested a review from edgarriba July 7, 2023 13:18
Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any demo or tutorial update would be nice for later. Is this the kinda last top model or still Loftr is the thing ?



class LightGlueMatcher(GeometryAwareDescriptorMatcher):
"""LightGlue-based matcher in kornia API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""LightGlue-based matcher in kornia API.
"""LightGlue-based matcher in kornia API.

@ducha-aiki
Copy link
Member Author

Loftr is still the thing, however, on some images LG is better and it definitely much faster.

@edgarriba
Copy link
Member

Loftr is still the thing, however, on some images LG is better and it definitely much faster.

would be great to update the tutorials or image matching page to explain when every model we have is useful

@ducha-aiki
Copy link
Member Author

ducha-aiki commented Jul 10, 2023

would be great to update the tutorials or image matching page to explain when every model we have is useful

and probably merge the most of image matching tutorials into single one, explaining the differences.

@ducha-aiki ducha-aiki mentioned this pull request Jul 12, 2023
@ducha-aiki
Copy link
Member Author

Closing in favour of #2449

@ducha-aiki ducha-aiki closed this Jul 12, 2023
@edgarriba edgarriba deleted the lightglue branch September 13, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants