Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Transformation Matrix Mis-calculation for autoaugmentations #2852

Merged
merged 11 commits into from Apr 2, 2024

Conversation

shijianjian
Copy link
Member

Fixes #2843

@shijianjian
Copy link
Member Author

weird. It passed on my local machine, but not here.

@johnnv1
Copy link
Member

johnnv1 commented Mar 25, 2024

weird. It passed on my local machine, but not here.

I'm not sure if it's me who added the skip, but if it was, that's why it was like randomness 😢

maybe it's just an adjust in the tolerance?

@shijianjian
Copy link
Member Author

weird. It passed on my local machine, but not here.

I'm not sure if it's me who added the skip, but if it was, that's why it was like randomness 😢

maybe it's just an adjust in the tolerance?

It is added by Dmytro I think. The point is after my fix, it totally works on my machine under Python3.8 and torch1.9.1. I do not know what is going on in the CI. XD

@johnnv1
Copy link
Member

johnnv1 commented Mar 27, 2024

It is added by Dmytro I think. The point is after my fix, it totally works on my machine under Python3.8 and torch1.9.1. I do not know what is going on in the CI. XD

in my local it is randomly falling xD

$ conda create -p venv38 python=3.8
$ conda install pytorch=1.9.1 cpuonly -c pytorch -c nvidia
$ pip install accelerate==0.20.3 # otherwise will install new torch
$ pip install -e .[dev,x]
# run it until fail
$ pytest tests/augmentation/test_auto_operation.py --device=cpu --dtype=float64,float32 -vv

some times the AILED tests/augmentation/test_auto_operation.py::TestOperations::test_step_routine[op5] (the op id change in each fail run too) also fail with

E       assert 0.5 != 0.5
E        +  where 0.5 = <built-in method item of Tensor object at 0x7ae54b77a900>()
E        +    where <built-in method item of Tensor object at 0x7ae54b77a900> = tensor([0.5000], grad_fn=<ClampBackward1>).item
E        +      where tensor([0.5000], grad_fn=<ClampBackward1>) = HorizontalFlip(\n  (op): RandomHorizontalFlip(p=0.5, p_batch=1.0, same_on_batch=False)\n).probability

btw, the number of warnings also changes a lot between each run (like between 5 and 13 warning)

@shijianjian shijianjian merged commit 9a5337c into kornia:main Apr 2, 2024
27 checks passed
@shijianjian shijianjian deleted the aug/automat branch April 2, 2024 23:30
cjpurackal pushed a commit to cjpurackal/kornia that referenced this pull request May 18, 2024
…rnia#2852)

* fixes kornia#2843

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix

* fixes kornia#2843

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix

* compress warnings

* update

* fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RanAug test failing
3 participants