Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now SIFTdesc throws an exception when the input parameters are incompatible #598

Merged
merged 4 commits into from Jul 30, 2020

Conversation

ducha-aiki
Copy link
Member

@ducha-aiki ducha-aiki commented Jul 29, 2020

…patible

Description

Addresses https://discuss.pytorch.org/t/kornia-sift-descriptor-output-size-not-consistent/78737

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.

If there are any questions regarding code style or other conventions check out our
summary.

  • Did you discuss the functionality or any breaking changes before ?
  • Pass all tests: did you test in local ? make test
  • Unittests: did you add tests for your new functionality ?
  • Documentations: did you build documentation ? make build-docs
  • Implementation: is your code well commented and follow conventions ? make lint
  • Docstrings & Typing: has your code documentation and typing ? make mypy
  • Update notebooks & documentation if necessary

KorniaTeam

KorniaTeam workflow
  • Assign correct label
  • Assign PR to a reviewer
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, Typing, Linting, Documentation, Environment)
  • Does the implementation follow kornia design conventions?
  • Is the documentation complete enough ?
  • Are the tests covering simple and corner cases ?

Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edgarriba edgarriba added the 1 Priority 1 🚨 High priority label Jul 30, 2020
@edgarriba edgarriba merged commit 6a9b661 into master Jul 30, 2020
@edgarriba edgarriba deleted the sift-size-bugfix branch July 30, 2020 08:45
edgarriba added a commit that referenced this pull request May 30, 2021
…patible (#598)

Co-authored-by: Edgar Riba <edgar.riba@gmail.com>
edgarriba added a commit to edgarriba/kornia that referenced this pull request Jul 6, 2021
…patible (kornia#598)

Co-authored-by: Edgar Riba <edgar.riba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants