Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Enable variable side resizing in kornia.resize #628

Merged
merged 9 commits into from Aug 26, 2020
Merged

[Feat] Enable variable side resizing in kornia.resize #628

merged 9 commits into from Aug 26, 2020

Conversation

pmeier
Copy link
Contributor

@pmeier pmeier commented Aug 14, 2020

Closes #627

@pmeier pmeier mentioned this pull request Aug 14, 2020
Closed
ducha-aiki
ducha-aiki requested changes Aug 24, 2020
View reviewed changes
Copy link
Member

@ducha-aiki ducha-aiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the PR, but really don't like name "edge" here. First thing, what I thought about, when opened PR, was edge from edge detection, and I think it is a common association.
Rename to, maybe, "side"?

@edgarriba
Copy link
Member

@ducha-aiki good point!

@pmeier pmeier changed the title Enable variable edge resizing Enable variable side resizing Aug 24, 2020
@pmeier
Copy link
Contributor Author

pmeier commented Aug 24, 2020

@ducha-aiki Rename is done.

@ducha-aiki
Copy link
Member

Thanks. LGTM

@edgarriba edgarriba changed the title Enable variable side resizing [Feat] Enable variable side resizing in kornia.resize Aug 26, 2020
@edgarriba edgarriba merged commit 92fa259 into kornia:master Aug 26, 2020
@pmeier pmeier deleted the resize-edge branch September 7, 2020 14:02
edgarriba pushed a commit that referenced this pull request May 30, 2021
@pmeier @ducha-aiki
[Feat] Enable variable side resizing in kornia.resize (#628)
ee07e26 
* add edge kwarg to resize

* fix docstring

* add tests

* add error message

* replace round with int

* lint

* rename 'edge' to 'size'

* rename left over

Co-authored-by: Dmytro Mishkin <ducha.aiki@gmail.com>
edgarriba pushed a commit to edgarriba/kornia that referenced this pull request Jul 6, 2021
@pmeier @ducha-aiki
[Feat] Enable variable side resizing in kornia.resize (kornia#628)
f0c1966 
* add edge kwarg to resize

* fix docstring

* add tests

* add error message

* replace round with int

* lint

* rename 'edge' to 'size'

* rename left over

Co-authored-by: Dmytro Mishkin <ducha.aiki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducha-aiki ducha-aiki ducha-aiki approved these changes

@shijianjian shijianjian Awaiting requested review from shijianjian

Assignees
No one assigned
Labels
PR: Good to Merge 👌
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the resize anchor variable if size is int
3 participants
@pmeier @edgarriba @ducha-aiki