Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 3D motion blur with element-wise implementations. #713

Merged
merged 11 commits into from Oct 19, 2020

Conversation

shijianjian
Copy link
Member

Description

A few sentences describing the changes proposed in this pull request.

Status

Ready/Work in progress/Hold

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.

If there are any questions regarding code style or other conventions check out our
summary.

  • Did you discuss the functionality or any breaking changes before ?
  • Pass all tests: did you test in local ? make test
  • Unittests: did you add tests for your new functionality ?
  • Documentations: did you build documentation ? make build-docs
  • Implementation: is your code well commented and follow conventions ? make lint
  • Docstrings & Typing: has your code documentation and typing ? make mypy
  • Update notebooks & documentation if necessary

KorniaTeam

KorniaTeam workflow
  • Assign correct label
  • Assign PR to a reviewer
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, Typing, Linting, Documentation, Environment)
  • Does the implementation follow kornia design conventions?
  • Is the documentation complete enough ?
  • Are the tests covering simple and corner cases ?

@edgarriba edgarriba linked an issue Oct 19, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #713 into master will increase coverage by 0.95%.
The diff coverage is 87.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage   87.36%   88.32%   +0.95%     
==========================================
  Files         104      103       -1     
  Lines        5818     5925     +107     
==========================================
+ Hits         5083     5233     +150     
+ Misses        735      692      -43     
Impacted Files Coverage Δ
kornia/augmentation/__init__.py 100.00% <ø> (ø)
.../augmentation/random_generator/random_generator.py 83.16% <ø> (+4.48%) ⬆️
kornia/filters/motion.py 71.42% <50.00%> (-28.58%) ⬇️
kornia/utils/image.py 86.20% <66.66%> (-5.10%) ⬇️
kornia/filters/kernels.py 92.30% <82.85%> (-1.59%) ⬇️
...ugmentation/random_generator/random_generator3d.py 35.84% <91.66%> (+16.33%) ⬆️
kornia/augmentation/augmentation.py 80.74% <100.00%> (+2.22%) ⬆️
kornia/augmentation/augmentation3d.py 65.71% <100.00%> (+10.15%) ⬆️
kornia/augmentation/functional/functional.py 64.04% <100.00%> (+0.90%) ⬆️
kornia/augmentation/functional/functional3d.py 48.87% <100.00%> (+6.01%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023da9a...ac3c734. Read the comment docs.

@edgarriba edgarriba added the 1 Priority 1 🚨 High priority label Oct 19, 2020
@edgarriba edgarriba merged commit 766bd71 into kornia:master Oct 19, 2020
@shijianjian shijianjian deleted the batch_motion_blur branch October 20, 2020 06:55
edgarriba pushed a commit that referenced this pull request May 30, 2021
* Made batch version of motion_kernel.

* Updated motion_blur augmentation.

* Added motionblur3d

* Added 3d motion blur

* Added RandomMotionBlur3D

* Added tests

* Lint fix

* Lint Fix
edgarriba pushed a commit to edgarriba/kornia that referenced this pull request Jul 6, 2021
* Made batch version of motion_kernel.

* Updated motion_blur augmentation.

* Added motionblur3d

* Added 3d motion blur

* Added RandomMotionBlur3D

* Added tests

* Lint fix

* Lint Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Priority 1 🚨 High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Add the same_on_batch for random motion blur
3 participants