Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit with hello world #1

Merged
merged 3 commits into from Jan 21, 2021
Merged

initial commit with hello world #1

merged 3 commits into from Jan 21, 2021

Conversation

edgarriba
Copy link
Member

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@edgarriba
Copy link
Member Author

edgarriba commented Oct 28, 2020

@ceroytres check it out. Not finished yet, in case you want to go ahead

@ceroytres
Copy link
Contributor

@edgarriba I created a fork based on this branch and I uploaded the ZCA notebook. I was a bit busy today so I didn't do much.

@edgarriba
Copy link
Member Author

@ceroytres now is compiling and generating the output. Need to add instructions and CI to verify that compiles:
to run:

pip install -t requirements.txt
make clean
make docs

check _build/index.html

@edgarriba
Copy link
Member Author

open questions: should we include the data here, wouldn;t be too much memory footprint for the repo in the long run ? how do we test that notebooks codes are not deprecated

@edgarriba
Copy link
Member Author

/cc @ducha-aiki @ducha-aiki any opinions on this ?

@ducha-aiki
Copy link
Member

Unles the data is very toy == couple of kilobytes, I think we should not include data directly.
Instead we should put smth like into top notebook cell:

!wget http://where-is-our-cool-data.zip
!unzip our-cool-data.zip

Codes - just run them? We can add the running into CLI:
https://nbconvert.readthedocs.io/en/latest/execute_api.html

jupyter nbconvert --to notebook --execute mynotebook.ipynb

@edgarriba
Copy link
Member Author

for example a separated repo with our data ?

@edgarriba
Copy link
Member Author

@lferraz suggests to use Github LFS: https://git-lfs.github.com to store data or even for testing

@edgarriba edgarriba merged commit feafb1e into main Jan 21, 2021
@edgarriba edgarriba changed the title initial commit with hello world (not working yet) initial commit with hello world Jan 21, 2021
@edgarriba edgarriba deleted the hello_world branch January 22, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants