Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FlatBuffers for cflamegraph files #30

Closed
kornilova203 opened this issue Jul 15, 2018 · 0 comments
Closed

Use FlatBuffers for cflamegraph files #30

kornilova203 opened this issue Jul 15, 2018 · 0 comments
Milestone

Comments

@kornilova203
Copy link
Owner

kornilova203 commented Jul 15, 2018

Snapshot version of plugin implements compressed version of flamegraph format.
But the new format is not binary therefore it is not optimal for saving disk space.
Also custom parser is implemented for the format and it is bug prone.

I suggest keeping structure of cflamegraph files but using FlatBuffers for serialization.

cflamegraph format will contain the same amount of information as regular flamegraph, therefore it will not be possible to directly use it for client-server communication #15, but it can be easily converted to more complex data.

I considered making cflamegraph format to be also client-server format, but then it would contain redundant information (that is set to speed up visualization) also client-server format may be changed and I do not want to worry about support for existing files.

@kornilova203 kornilova203 added this to the v0.8.1 milestone Jul 15, 2018
@kornilova203 kornilova203 changed the title Use Cap'n Proto for cflamegraph files Use FlatBuffers for cflamegraph files Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant