feature: add prefix settings #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takayamaki
force-pushed
the
feature/add-prefix-settings
branch
from
5577672
to
91f559e
Compare
takayamaki
force-pushed
the
feature/add-prefix-settings
branch
from
91f559e
to
8a3a5b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tweetの冒頭に付けるprefixを設定できるようにします。
オプション画面のjsについては、アロー関数形式に書き換えた以外は概ね https://developer.chrome.com/extensions/options のままです。
prefixの設定がされていない場合に参照される
JustTweet/src/settings/settings.js
Line 18 in 5577672
' » 'とベタ書きしようとすると、オプション画面のtextboxに代入される際になぜか»と化けてしまいうまくいかなかったため、ユニコードの数値参照に書き換えました。