Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with discovery on Android 13 #33

Closed

Conversation

alexballas
Copy link

No description provided.

@alexballas alexballas marked this pull request as draft May 27, 2023 14:34
@alexballas
Copy link
Author

alexballas commented May 27, 2023

Converting to draft @koron fyi
According to the following documentation

func (*ipv4.dgramOpt).JoinGroup(ifi *net.Interface, group net.Addr) error
JoinGroup joins the group address group on the interface ifi. By default all sources that can cast data to group are accepted. It's possible to mute and unmute data transmission from a specific source by using ExcludeSourceSpecificGroup and IncludeSourceSpecificGroup. JoinGroup uses the system assigned multicast interface when ifi is nil, although this is not recommended because the assignment depends on platforms and sometimes it might require routing configuration.

Passing nil to the interfaces will use the system assigned multicast interface, which seems to work fine in Android without worrying about calling net.Interfaces()

@alexballas alexballas force-pushed the bugfix/android_13_discovery_error branch from a8eed65 to 73297ef Compare May 29, 2023 17:01
@koron koron closed this Oct 17, 2023
@koron
Copy link
Owner

koron commented Oct 17, 2023

thank you for notifying this.

i closed this pull request for two reasons.

  1. android is not a primary OS which Go supports
  2. looks like it can be implemented without including android-specific code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants