Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RST visualizer doesn't work in ANNIS4 #696

Closed
amir-zeldes opened this issue Apr 15, 2021 · 0 comments · Fixed by #700
Closed

RST visualizer doesn't work in ANNIS4 #696

amir-zeldes opened this issue Apr 15, 2021 · 0 comments · Fixed by #700
Labels
bug

Comments

@amir-zeldes
Copy link
Collaborator

Describe the bug
RST visualizer does not display EDU leaf tokens and edges around them are rendered incorrectly

To Reproduce

Steps to reproduce the behavior:

  1. Use Desktop version under Win 10 64 + Chrome
  2. Import GUM V7
  3. Run a query and expand RST visualizer

Screenshots

image

Desktop (please complete the following information):

  • Operating System: Win 10 64
  • Browser: Chrome
  • Java Version: openjdk version "1.8.0_252"
  • ANNIS Version: ANNIS 4 beta 6
thomaskrause added a commit that referenced this issue May 10, 2021
@thomaskrause
Do not discard dominance edge, when only the target node has an incom…
1f7a703 
…ing unnamed incoming edge.

For the GUM corpus with mixed dominance for syntax and RST trees, this caused some segments to have no connection to any token. Fixes #696
@thomaskrause thomaskrause mentioned this issue May 10, 2021
Merged
thomaskrause added a commit that referenced this issue May 10, 2021
@thomaskrause
Do not discard dominance edge, when only the target node has an incom…
d0589b9 
…ing unnamed incoming edge.

For the GUM corpus with mixed dominance for syntax and RST trees, this caused some segments to have no connection to any token. Fixes #696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@amir-zeldes