Fix potential bugs by switching from Formatting.jl to Format.jl #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 82.38% 82.66% +0.27%
==========================================
Files 21 21
Lines 829 819 -10
==========================================
- Hits 683 677 -6
+ Misses 146 142 -4 ☔ View full report in Codecov by Sentry. |
ScottPJones
force-pushed
the
spj/useformat
branch
from
112f619
to
c77f093
Compare
ScottPJones
force-pushed
the
spj/useformat
branch
from
c77f093
to
cf8b97f
Compare
|
Note: the failure on nightly happens on master, and is unrelated to this PR, and the Documentation check is also unrelated to the change. Can this be merged now? Thanks in advance! |
|
This looks good to me. |
|
Can this be merged? |
Just waiting on someone who has permission to do so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also eliminated the need to do @eval at run-time just for numeric formatting, which also eliminates the need for Printf as a dependency.