-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set depth to 1 when fetching #268
Conversation
|
Only merged pull requests can be backported. |
|
Only merged pull requests can be backported. |
Never mind 🙃 got ahead of myself, didn't realize it failed, sorry.
|
Only merged pull requests can be backported. |
Closing (for now). |
Doesn't help that both stdout and stderr of
|
Only merged pull requests can be backported. |
Haha sorry about that. I've disabled the action for now, it's not really needed in this project anyways (I don't support multiple versions yet). Although it is strange that the action triggered on issue_comments that didn't themselves contain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably not work correctly in all cases, as not enough commits are fetched when the PR contains multiple commits or the target branch contains multiple commits since the PR was branched.
EDIT: 🤔 I'm not sure how to determine the number of commits to fetch on the base branch (PR target), perhaps we should simply fetch 1000 commits to start. That's already a factor 400 improvement for nixpkgs
. We can further improve it if a need arises.
PS: thanks for giving it a try 🙇
This reduces the backport time on even large repositories to mere seconds, and closes #267.