[Backport release-v1.3] Publish artifacts on release branches #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The CI was supposed to publish artifacts on the main branch and on release branches. However, I misread the documentation for the `contains(search, item)` expression. I expected that search is the value to search for, while item is the thing to search in. It is actually the other way around: search is the thing to search in, and item is what is searched for. In addition, contains might not be explicit enough. So for safeguarding it may be better to use `startsWith(searchString, searchValue)`. This function 'Returns true when searchString starts with searchValue'. This problem should now be resolved. (cherry picked from commit dceff6b)
korthout
force-pushed
the
backport-346-to-release-v1.3
branch
from
c06b480
to
90a022c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #346 to
release-v1.3.